Page 1 of 1

Serviio bug in reading the Album tag from FLAC files

PostPosted: Thu Jan 09, 2014 10:06 am
by n3mmr
The album title

"Berwald - Symphonie nr 4"

will be read by Serviio as "Berwald ".

Hmm.

Re: Serviio bug in reading the Album tag from FLAC files

PostPosted: Mon Jan 13, 2014 5:31 am
by zip
i HAVE CREATED A YICKET: https://bitbucket.org/xnejp03/serviio/i ... -truncated

Could you send me the file or attach to the ticket?

Re: Serviio bug in reading the Album tag from FLAC files

PostPosted: Mon Jan 13, 2014 8:22 am
by n3mmr
zip wrote:i HAVE CREATED A YICKET: https://bitbucket.org/xnejp03/serviio/i ... -truncated

Could you send me the file or attach to the ticket?

Actually, I'd say that the problem is a "poison character", "-" makes Serviio not read the rest of the tag.

This is using the linux distro.

It applies to ALL tags in all my files.

I'll construct a file that I can legally send.

Can you or somebody else check if this happens generally or if it might be related to my specific environment before I waste your time? Could be character encoding related.

Re: Serviio bug in reading the Album tag from FLAC files

PostPosted: Thu Jan 16, 2014 8:28 am
by zip
Im still on holidays for a few more days, but will check when i'm back. A file by then would be great.

Re: Serviio bug in reading the Album tag from FLAC files

PostPosted: Fri Jan 17, 2014 10:57 am
by n3mmr
zip wrote:Im still on holidays for a few more days, but will check when i'm back. A file by then would be great.


While making this testfile I found some more confusing behaviour.

Please investigate what YOU see, I tried it with serviio and ffmpeg 1.2.1 and I get two distinct ways to do it wrong... :-)

For the menu system, Serviio consistently uses the part PRECEDING the '-', ffmpeg consistently reports the part AFTER the '-'.

Ah well.

I've tried to look for some kind of documentation on what you're supposed to do about any old character present in tags, but Ogg Vorbis and FLAC (xiph.org) seem to say that ANY character should be allowed in any tag and any tag must be able to have absolutely any value, up to a fairly long string of characters.

However, many implementations do it wrong and in different ways. Serviio and ffmpeg are but two of the less surprising ones.

Still, since nowadays, people will start using DLNA servers more and more for serving up downloaded commercial flacs, I really think it is important for any software using tag values for anything at all to NOT apply arbitrary limitations.

If the Album tag is "Dvorak - The Master of Harmony", then the Album menu should show "Dvorak - The Master of Harmony" for that album. OK??

I mean, there might be another album "Dvorak - The American Period", and we do want those two to be distinguishable in the Serviio menu system, don't we?

The testtags.flac file has all the tags shown by easytag filled in in the same pattern: Like Album contains "Tome - Album". I e "<French word for the tag label><blank>-<blank><english word for the label>"

Title, Artist, Album Artist, Album, Genre, Comment, Composer, Orig Artist, Copyright, URL, Coded By have been filled in, i e all the easytag visible tags that accept alpha chars.

Re: Serviio bug in reading the Album tag from FLAC files

PostPosted: Fri Jan 17, 2014 11:37 am
by n3mmr

Re: Serviio bug in reading the Album tag from FLAC files

PostPosted: Sun Jan 26, 2014 8:31 pm
by zip
The test file is a bit weird. It has some tags twice (like Album, with values: Dump and Album) - see VLC, it shows album Dump.

Re: Serviio bug in reading the Album tag from FLAC files

PostPosted: Mon Jan 27, 2014 9:51 am
by n3mmr
zip wrote:The test file is a bit weird. It has some tags twice (like Album, with values: Dump and Album) - see VLC, it shows album Dump.



So what?? It's a prepared special to demonstrate the problem:

All tags were entered into easytag as:

frenchword<blank>"-"<blank>englishword

except one instance where the "frenchword" part was entered as "Dump"

Like this:
Titre - Title
Artiste - Artist
Artiste de tome - Album Artist
Dump - Album
Genre Classical - Symphonie Classique
Commentaire - Comment
Compositeur - Composer
Artiste d'Origine - Orig Artist
droits de tome - Copyright
Loca de resource universelle - Univ Res Loca
Encodé par - Coded By

where the englishword is indicative of the tag label.

There are NO duplicate tags! If you see different tags with different SW reading the file, then one or more of those SW have problems reading the tags in this file.

Most programs showing the tags of this file have some problem with at least some tags containing the character "-".
Some report the complete string including the "-", some programs report the part preceding the "-", some report the part AFTER the "-" character. Some report nothing at all for some tags.

Re: Serviio bug in reading the Album tag from FLAC files

PostPosted: Mon Jan 27, 2014 5:39 pm
by zip
If you look at the file in a hex editor, some of the tags are split, like:

TITLE=Titre TITLE=Title

while

TIT2Titre - Title

So TIT2 has the right value, TITLE is split in 2 with the same key. I assume the library and some of your other programs are reading TITLE tag and picking one of them.

This GStreamer bug seems to suggest it's an issue with EasyTag: https://bugzilla.gnome.org/show_bug.cgi?id=670287

Re: Serviio bug in reading the Album tag from FLAC files

PostPosted: Sat Feb 01, 2014 8:13 pm
by maltmoose
That test flac file has flac tags AND id3v2 tags

its bad practice to have id3v2 on a flac file

So there are duplicate tags! and as zip says its weird and will only cause inconsistencies.

mp3tag is a reliable tagger and foobar2000 a reliable player with tagger, windows only but probably work ok under linux

Re: Serviio bug in reading the Album tag from FLAC files

PostPosted: Sun Feb 02, 2014 2:13 pm
by n3mmr
zip wrote:If you look at the file in a hex editor, some of the tags are split, like:

TITLE=Titre TITLE=Title

while

TIT2Titre - Title

So TIT2 has the right value, TITLE is split in 2 with the same key. I assume the library and some of your other programs are reading TITLE tag and picking one of them.

This GStreamer bug seems to suggest it's an issue with EasyTag: https://bugzilla.gnome.org/show_bug.cgi?id=670287


Hmm...

I'll just have to look at other tagging tools, first.

Thanks for helping out!